New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not throw when creating type annotation based on bigint #12971
fix: do not throw when creating type annotation based on bigint #12971
Conversation
JLHwung
commented
Mar 5, 2021
•
edited
edited
Q | A |
---|---|
Fixed Issues? | Closes #12965, fixes #13018 |
Patch: Bug Fix? | Y |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44375/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5eee3af:
|
} else if (type === "bigint") { | ||
// todo: use BigInt annotation when Flow supports BigInt | ||
// https://github.com/facebook/flow/issues/6639 | ||
return anyTypeAnnotation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not use numberTypeAnnotation
here because Math
functions do not work with BigInt. Mark it as any
as it is not supported in Flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future we could consider moving away from Flow as an internal representation of types.